Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update RSCT operator status #51

Merged
merged 1 commit into from
Nov 7, 2024
Merged

Update RSCT operator status #51

merged 1 commit into from
Nov 7, 2024

Conversation

manju956
Copy link
Contributor

@manju956 manju956 commented Oct 1, 2024 •
edited
Loading

  • Update RSCT operator status based on observed status of pods spun by the operator
  • Address requirements of the issue Release RSCT Operator  #44
  • Add required Cluster Service Version fields

@ppc64le-cloud-bot
Copy link
Contributor

Welcome @manju956! It looks like this is your first PR to ocp-power-automation/rsct-operator 🎉

@manju956 manju956 force-pushed the rsct-operator-status branch 5 times, most recently from 9544aa3 to c8774a0 Compare October 9, 2024 06:10
@manju956 manju956 force-pushed the rsct-operator-status branch from c8774a0 to 606b665 Compare October 14, 2024 16:29
mkumatag
mkumatag requested changes Oct 23, 2024
View reviewed changes
internal/controller/status.go Outdated Show resolved Hide resolved
internal/controller/status.go Outdated Show resolved Hide resolved
internal/controller/status.go Show resolved Hide resolved
api/v1alpha1/rsct_types.go Outdated Show resolved Hide resolved
@manju956 manju956 force-pushed the rsct-operator-status branch 4 times, most recently from e16b880 to 703c7bf Compare October 24, 2024 06:36
mkumatag
mkumatag requested changes Nov 4, 2024
View reviewed changes
config/manager/kustomization.yaml Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
internal/controller/status.go Outdated Show resolved Hide resolved
internal/controller/status.go Outdated Show resolved Hide resolved
internal/controller/status.go Outdated Show resolved Hide resolved
@manju956 manju956 force-pushed the rsct-operator-status branch 3 times, most recently from 319fb55 to c1ca3fb Compare November 4, 2024 09:19
@mkumatag
Copy link
Member

mkumatag commented Nov 4, 2024 •
edited
Loading

btw: there is something wrong with your GitHub user configuration, please fix that

image

mkumatag
mkumatag approved these changes Nov 4, 2024
View reviewed changes
Copy link
Member

@mkumatag mkumatag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@mkumatag
Copy link
Member

mkumatag commented Nov 4, 2024

/hold

@mkumatag
Copy link
Member

mkumatag commented Nov 4, 2024

and squash the commits as well.

@manju956 manju956 force-pushed the rsct-operator-status branch from c1ca3fb to 6a5775d Compare November 6, 2024 05:16
@manju956 manju956 force-pushed the rsct-operator-status branch from 6a5775d to 200ce29 Compare November 6, 2024 05:17
@manju956
Copy link
Contributor Author

manju956 commented Nov 6, 2024

btw: there is something wrong with your GitHub user configuration, please fix that

image

@mkumatag May I know what's wrong with user configuration?

@mkumatag
Copy link
Member

mkumatag commented Nov 7, 2024

May I know what's wrong with user configuration?

I think you have fixed it, see a proper link to your commit..

mkumatag
mkumatag approved these changes Nov 7, 2024
View reviewed changes
Copy link
Member

@mkumatag mkumatag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ppc64le-cloud-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: manju956, mkumatag

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@manju956
Copy link
Contributor Author

manju956 commented Nov 7, 2024

/lgtm

@mkumatag can you remove do-not-merge label so that we can merge the PR?

@mkumatag
Copy link
Member

mkumatag commented Nov 7, 2024

/unhold

@ppc64le-cloud-bot ppc64le-cloud-bot merged commit 1b996b4 into ocp-power-automation:main Nov 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@varad-ahirwadkar varad-ahirwadkar varad-ahirwadkar left review comments

@mkumatag mkumatag mkumatag approved these changes

Assignees

@mkumatag mkumatag

Labels
approved lgtm size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@manju956 @ppc64le-cloud-bot @mkumatag @varad-ahirwadkar