Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(run-script-against-repos): add support for capital letters for user&repo #42

Merged
merged 1 commit into from
May 14, 2021

Conversation

oscard0m
Copy link
Member

@oscard0m oscard0m commented May 14, 2021

πŸ“ Summary

  • Improve pattern of repositories to give support for user/org and repository with capital letters

β›± Motivation and Context

Repository names and Organization/User names for GitHub are case insensitive.

Fix #41

πŸ“Š How Has This Been Tested?

Testing the RegEx pattern here: https://regexr.com/5su0n

Modifying a local script with these changes:

Before

image

After

image

@oscard0m
Copy link
Member Author

Opening a new issue to discuss testing for this: #43

Copy link
Member

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great πŸ‘πŸΌ

@gr2m gr2m merged commit d8b9c7a into main May 14, 2021
@gr2m gr2m deleted the add-support-for-capital-letters-for-repos-and-orgs branch May 14, 2021 16:52
@github-actions
Copy link

πŸŽ‰ This PR is included in version 3.3.2 πŸŽ‰

The release is available on:

Your semantic-release bot πŸ“¦πŸš€

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Owner with upper-case fails
2 participants