Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report unreachable dispatcher in report_progress to sentry #229

Open
dsavchenko opened this issue Dec 6, 2023 · 2 comments
Open

Report unreachable dispatcher in report_progress to sentry #229

dsavchenko opened this issue Dec 6, 2023 · 2 comments
Assignees
@okolo

Comments

@dsavchenko
Copy link
Member

Following #225 (comment)
@dsavchenko dsavchenko mentioned this issue Dec 6, 2023
Merged
@volodymyrss
Copy link
Member

@okolo could you please have a look?

@okolo
Copy link
Contributor

okolo commented Feb 19, 2024

@volodymyrss Do you suggest to rise an exception in ProgressReporter.report_progress? Another option would be to write to log. And third option would be to make an extra parameter raise_error which would give user the choice and keep the code compact at the same time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@okolo okolo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@okolo @volodymyrss @dsavchenko