-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
217 add functionality to send callback messages #225
217 add functionality to send callback messages #225
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #225 +/- ##
==========================================
+ Coverage 57.18% 57.70% +0.51%
==========================================
Files 22 23 +1
Lines 4723 4781 +58
==========================================
+ Hits 2701 2759 +58
Misses 2022 2022 ☔ View full report in Codecov by Sentry. |
Is it also possible to add a test? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should an instance of the ProgressReporter
be a member of any DispatcherAPI
object?
I think it would be more clean and transparent
Please add docs too, @okolo . See where they appear for this PR . |
Because it's a different way to access dispatcher, it may be a separate class. |
Progress reporter API was added