Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

217 add functionality to send callback messages #225

Merged
merged 11 commits into from
Jan 10, 2024

Conversation

okolo
Copy link
Contributor

@okolo okolo commented Nov 7, 2023

Progress reporter API was added

@okolo okolo linked an issue Nov 7, 2023 that may be closed by this pull request
Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (f8ce41a) 57.18% compared to head (a13948d) 57.70%.

Files Patch % Lines
oda_api/api.py 85.71% 4 Missing ⚠️
tests/test_progress_report.py 90.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #225      +/-   ##
==========================================
+ Coverage   57.18%   57.70%   +0.51%     
==========================================
  Files          22       23       +1     
  Lines        4723     4781      +58     
==========================================
+ Hits         2701     2759      +58     
  Misses       2022     2022              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

oda_api/api.py Outdated Show resolved Hide resolved
oda_api/api.py Outdated Show resolved Hide resolved
@burnout87
Copy link
Collaborator

Is it also possible to add a test?

oda_api/api.py Outdated Show resolved Hide resolved
oda_api/api.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@burnout87 burnout87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should an instance of the ProgressReporter be a member of any DispatcherAPI object?

I think it would be more clean and transparent

tests/test_progress_report.py Outdated Show resolved Hide resolved
@volodymyrss
Copy link
Member

Please add docs too, @okolo . See where they appear for this PR .

@volodymyrss
Copy link
Member

Should an instance of the ProgressReporter be a member of any DispatcherAPI object?

I think it would be more clean and transparent

Because it's a different way to access dispatcher, it may be a separate class.

@burnout87 burnout87 self-requested a review December 12, 2023 10:28
@volodymyrss volodymyrss merged commit 961a316 into master Jan 10, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add functionality to send callback messages
4 participants