This repository has been archived by the owner on Jun 27, 2020. It is now read-only.
Rw user sees list of orgs #76
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hpjaj
reviewed
Dec 15, 2018
hpjaj
reviewed
Dec 15, 2018
| @@ -224,7 +224,7 @@ export default class Profile extends Component { | |||
| <div className="flex-col w-1/2 mt-10 p-5 bg-gray m-auto bg-grey-lightest border border-grey rounded"> | |||
| <UpdateAccessToken hasAccessToken={data.me.hasAccessToken} /> | |||
| <UpdateGithubUsername githubUsername={data.me.githubUsername} /> | |||
| <UpdateGithubOrg orgs={MOCK_ORGS} /> | |||
There was a problem hiding this comment.
Can you pls remove the MOCK_ORGS const, también
|
Heads up, there's a unique key iterator warning on profile:
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
In order for a user to select which org they are a part of, they need to see a real list of organizations
Issue Resolved
Closes #70
Definition of Done