Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(extractors/services): add atuin #26

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

IogaMaster
Copy link
Contributor

  • feat(extractors/services): add atuin

image

@IogaMaster
Copy link
Contributor Author

Side note, it seems the last commit was not formatted.

@oddlama
Copy link
Owner

oddlama commented May 6, 2024

Something doesn't seem quite right here, your second commit changes almost every line in the file

@jaredmontoya
Copy link
Contributor

jaredmontoya commented Nov 7, 2024

It changes almost every line in the file because it's a formatting change.

I checked out his branch and reverted his style commit then executed nix fmt and it got formatted again, that means that the style of the file that he changed is wrong.

I think that the only way that this could happen in your codebase is if someone ignored your pre-commit checks before submitting a PR.

If I were you I would ditch pre-commit hooks and would just use treefmt-nix to define both formatters and checks for them so that if you want to satisfy checks you only need to execute nix fmt and it will be guaranteed. Then use nix flake check on the CI pipeline to enforce compliance. Also treefmt-nix allows you to format non-nix code with nix fmt.

This is a go project that I wrote a nix flake for: fabric
you can reference it's treefmt-nix configuration as a minimal example. It also doesn't use flake-utils, I suggest you to ditch flake-utils too if you only need them for a single function that iterates over a list of systems. It's not worth it to download all that code to just use a small fraction of it.

I already implemented all of this for you: #46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants