Fix display issue w/select_multiple #215
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parseSaveValue(savedValue) did not work correctly, as it was receiving a savedValue of type string, but treated it as an array, causing it to not display the selected items correctly (and also doing an unfortunate iteration on savedValue.length - which then was the string length and not the array length as the code expected).
|
(I also took the opportunity to get rid of the 'not specified' placeholder value that appears in text boxes) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix an issue with select_multiple not displaying selected values
parseSaveValue(savedValue)does not work correctly, as it receives a 'savedValue' of typestring, but treats it as anarray, causing it to not display the selected items correctly (and also doing an unfortunate iteration on savedValue.length - which then of course is the string length of the concatenated selected items (!) and not the array length as the code expected).