Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Image in scan docs #139

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

Shubhamr837
Copy link

What is included in this PR?
Old Image of Suitcase is updated.

Copy link
Contributor

@elmps2018 elmps2018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Shubhamr837! Thanks for working on this documentation! If this is substituting for the current suitcase-scan.png, I think it should have the checkbox and red underline added like the original to help folks see what to check.

@Shubhamr837
Copy link
Author

Sure! I will update the image by end of this week as we are also going to implement changes for the new colors specified in https://docs.google.com/presentation/d/1j-KCXoJr_QvApP8P5bkcI-qlFUW2oqH5LiqaErWXcrI/edit?usp=sharing.

@Shubhamr837
Copy link
Author

@elmps2018 please ignore this update. I am uploading it again with the red underline.

@Shubhamr837
Copy link
Author

@elmps2018 I have updated the Image. Please Suggest If any other change is needed.
suitcase-scan

@elmps2018
Copy link
Contributor

@Shubhamr837 this looks good! Should we wait to merge until the new Suitcase app goes out?

@Shubhamr837
Copy link
Author

Shubhamr837 commented Aug 19, 2021

I think we should wait because it will be confusing for someone who goes through the documentation and finds a different screen shot.

@wbrunette wbrunette added this to the Release Version 2.1.9 milestone Oct 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants