-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Image in scan docs #139
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Shubhamr837! Thanks for working on this documentation! If this is substituting for the current suitcase-scan.png, I think it should have the checkbox and red underline added like the original to help folks see what to check.
Sure! I will update the image by end of this week as we are also going to implement changes for the new colors specified in https://docs.google.com/presentation/d/1j-KCXoJr_QvApP8P5bkcI-qlFUW2oqH5LiqaErWXcrI/edit?usp=sharing. |
@elmps2018 please ignore this update. I am uploading it again with the red underline. |
@elmps2018 I have updated the Image. Please Suggest If any other change is needed. |
@Shubhamr837 this looks good! Should we wait to merge until the new Suitcase app goes out? |
I think we should wait because it will be confusing for someone who goes through the documentation and finds a different screen shot. |
What is included in this PR?
Old Image of Suitcase is updated.