-
Notifications
You must be signed in to change notification settings - Fork 26.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] l10n_es: split IRPF 19% in two, depending on target model #161633
Conversation
Purchase IRPF 19% Spanish tax has 2 target models: 111 and 123. New law requires a more specific breakdown. Now, the tax for 111 is relabeled as "Retenciones IRPF 19% (Compra consejero de persona física)" to be more accurate, and the new one for model 123 is named "Retenciones IRPF 19% (Compra consejero de sociedad)". Since Odoo doesn't implement model 123 yet, that new tax includes no repartition lines. See OCA/l10n-spain#3520 for more context. OPW-3864840 @moduon MT-5767 Co-authored-by: Loida Vilaplana <[email protected]>
OPW-3864840 |
@jco-odoo does this tax change need a |
@robodoo r+ |
Purchase IRPF 19% Spanish tax has 2 target models: 111 and 123. New law requires a more specific breakdown. Now, the tax for 111 is relabeled as "Retenciones IRPF 19% (Compra consejero de persona física)" to be more accurate, and the new one for model 123 is named "Retenciones IRPF 19% (Compra consejero de sociedad)". Since Odoo doesn't implement model 123 yet, that new tax includes no repartition lines. See OCA/l10n-spain#3520 for more context. OPW-3864840 @moduon MT-5767 closes #161633 Signed-off-by: Josse Colpaert <[email protected]> Co-authored-by: Loida Vilaplana <[email protected]>
1 similar comment
4 similar comments
Hello, |
I confirm there's an issue when the update taxes migration script is executed. |
Do you have any tracebacks or STR? |
Hello Jairo, The new tax template pass this if, and trigger the ValidationError : 0 != 1
|
Hello Jairo, I'm trying to upgrade the database and also have the same issue because the new tax template has been added. Traceback :
|
🤔 However it is a percent. The problem is that the tax cannot have repartition lines because Odoo doesn't support the report it targets. What do you suggest? |
You can have repartition lines, but without tax tags. |
I was surprised myself that it passed on runbot, but indeed, better to have it with repartition lines, but without tax tags. |
@jco-odoo if we have them without tax tags then we cannot map them to AEAT models |
Purchase IRPF 19% Spanish tax has 2 target models: 111 and 123.
New law requires a more specific breakdown.
Now, the tax for 111 is relabeled as "Retenciones IRPF 19% (Compra
consejero de persona física)" to be more accurate, and the new one for
model 123 is named "Retenciones IRPF 19% (Compra consejero de
sociedad)".
Since Odoo doesn't implement model 123 yet, that new tax includes no
repartition lines.
See OCA/l10n-spain#3520 for more context.
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
@moduon MT-5767
Ticket link: https://www.odoo.com/web#model=project.task&id=3864840
opw-3864840