[ADD] estate: new estate module #324
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apri-odoo
commented
Feb 6, 2025
apri-odoo
commented
- introduced new estate module
|
|
sjai-odoo
suggested changes
Feb 6, 2025
estate/__init__.py
Outdated
| @@ -0,0 +1 @@ | |||
| from . import models | |||
There was a problem hiding this comment.
Add a blank line at the end of the file
estate/__manifest__.py
Outdated
| @@ -0,0 +1,15 @@ | |||
| { | |||
| 'name': 'Estate', | |||
| 'version':'1.0.0', | |||
There was a problem hiding this comment.
Suggested change
| 'version':'1.0.0', | |
| 'version':'1.0', |
estate/__manifest__.py
Outdated
| 'version':'1.0.0', | ||
| 'depends': ['base'], | ||
| 'description': """ | ||
| This is a base version of the Estate module for real estate management. |
There was a problem hiding this comment.
Suggested change
| This is a base version of the Estate module for real estate management. | |
| This is a base version of the Estate module for real estate management. |
sjai-odoo
reviewed
Feb 6, 2025
estate/__manifest__.py
Outdated
Comment on lines
12
to
14
| 'installable': True, | ||
| 'application': True, | ||
| 'auto_install': False, |
There was a problem hiding this comment.
Suggested change
| 'installable': True, | |
| 'application': True, | |
| 'auto_install': False, | |
| 'application': True, |
installable is True by default no need to add it explicitely
auto_install is only useful when you have other modules as dependencies, it makes no sense here.
sjai-odoo
suggested changes
Feb 6, 2025
estate/models/estate_property.py
Outdated
Comment on lines
16
to
17
| garage = fields.Boolean() | ||
| garden = fields.Boolean() |
There was a problem hiding this comment.
Suggested change
| garage = fields.Boolean() | |
| garden = fields.Boolean() | |
| is_garage = fields.Boolean() | |
| is_garden = fields.Boolean() |
Try to define boolean fields in this way which make it more readable and easy to code.
apri-odoo
force-pushed
the
18.0-training-apri
branch
from
95bbd57 to
82a3ce3
Compare
-ADD- estate models -ADD- __init_.py -ADD- estate_property.py -ADD- estate security -ADD- ir.model.access.csv -ADD- link this csv to esate/__manifest__.py
-Introduce security so that we can manage who can access that models. -In security ;add two file one is .CSV & another one is .XML -Introduce views ;define properties and menu's
apri-odoo
force-pushed
the
18.0-training-apri
branch
from
82a3ce3 to
afe2d0d
Compare
-upgrade XML file with list,form,view -[FIX] Replaced 'status' with 'state' in estate_property_views.xml.
sjai-odoo
suggested changes
Feb 10, 2025
estate/models/estate_property.py
Outdated
| _description = "Real Estate Property" | ||
|
|
||
| name = fields.Char(required=True) | ||
| # active field define here |
There was a problem hiding this comment.
Suggested change
| # active field define here |
estate/models/estate_property.py
Outdated
|
|
||
| name = fields.Char(required=True) | ||
| # active field define here | ||
| active = fields.Boolean(string="Active",default=True) |
There was a problem hiding this comment.
Suggested change
| active = fields.Boolean(string="Active",default=True) | |
| active = fields.Boolean(string="Active", default=True) |
when we define a field with more than one parameters add a space between them to make it clear
Comment on lines
43
to
48
| <group> | ||
| <h1> | ||
| <field name="name"/> | ||
| </h1> | ||
| </group> | ||
| <newLine/> |
There was a problem hiding this comment.
Suggested change
| <group> | |
| <h1> | |
| <field name="name"/> | |
| </h1> | |
| </group> | |
| <newLine/> | |
| <h1> | |
| <field name="name"/> | |
| </h1> |
Try to avoid unnecessary tags. when we give h1 under group it will again remove the label than why to add it.
| <field name="bedrooms" string="Bedrooms" /> | ||
| <field name="living_area" string="Living Area (sqm)" /> | ||
| <field name="facades" string="Facades" /> | ||
| <filter name="state" string="Available" domain="['|',('state', '=', 'new'), ('state' , '=' , 'offer_accept')]"/> |
There was a problem hiding this comment.
Suggested change
| <filter name="state" string="Available" domain="['|',('state', '=', 'new'), ('state' , '=' , 'offer_accept')]"/> | |
| <filter name="state" string="Available" domain="['|',('state', '=', 'new'), ('state' , '=' , 'offer_accept')]"/> |
try to do this without | operator.
apri-odoo
force-pushed
the
18.0-training-apri
branch
from
b160838 to
7b5e9b5
Compare
-add the Real Estate Property Type table. -add the buyer and the salesperson. -introduce property tag and offers
apri-odoo
force-pushed
the
18.0-training-apri
branch
from
7b5e9b5 to
ad5a089
Compare
-add total price calculate from living & garden area using compute. -add best offer from maximum price.
apri-odoo
force-pushed
the
18.0-training-apri
branch
from
f99365a to
8e85492
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.