Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 고객센터 약관 동의 및 context 추가 #229

Merged
merged 11 commits into from
Oct 17, 2023
Merged

Conversation

imdaxsz
Copy link
Contributor

@imdaxsz imdaxsz commented Oct 16, 2023

📝 개요

고객센터 약관 동의 부분을 추가하고, 문의 데이터 전역 관리를 위해 context를 추가하였습니다.

helpdesk.mp4

🚀 변경사항

  • 약관 전체 보기 페이지 추가
  • LoadContainer height 수정 100% -> 100dvh
  • Header center(title) 영역 스타일 수정 (약관 동의처럼 title이 긴 경우 두 줄로 넘어가는 현상 방지)
  • checkbox 컴포넌트 cursor pointer 및 id props 추가

🔗 관련 이슈

#80 #145 #46

➕ 기타

약관 미동의 시 snackbar 띄우는 걸로 일단 해보았는데 다른 의견 있으시면 말씀해 주세요!
그 외 잘못된 부분이나 개선할 부분이 있으면 코멘트 남겨주세요~

@imdaxsz imdaxsz added feature 새 기능 추가 fix 버그 등 수정 refactor 리팩토링 labels Oct 16, 2023
@imdaxsz imdaxsz self-assigned this Oct 16, 2023
Comment on lines -4 to -5
const [form, setForm] = useState({ email: "", title: "", content: "" });
const [error, setError] = useState({ email: 0, title: 0, content: 0 });
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

common/hooks/useForm이라는 이름이 나중에 겹치거나 찾을때 조금 어렵지 않을까 생각이 들어요~

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

common/hooks/useInquiryForm 이건 괜찮을까요?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋습니답

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Oct 17, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: b5386eb
Status: ✅  Deploy successful!
Preview URL: https://e434f5c0.oduck-client.pages.dev
Branch Preview URL: https://feature-80.oduck-client.pages.dev

View logs

Copy link
Collaborator

@presentKey presentKey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👍

@imdaxsz imdaxsz merged commit e89b64b into develop Oct 17, 2023
@imdaxsz imdaxsz deleted the feature/80 branch October 17, 2023 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature 새 기능 추가 fix 버그 등 수정 refactor 리팩토링
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants