-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: 프로필 페이지 코드 리팩토링 #376
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chanwukim
approved these changes
Apr 30, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 개요
🚀 변경사항
TabMenu
컴포넌트 예시useTabMenu
훅 내부에서UI 로직
과데이터 fetch 로직
이 함께 있었습니다. 이로 인해 컴포넌트가 복잡하고 불필요한 렌더링이 발생했습니다.이 문제를 개선하기 위해 비즈니스 로직을 관심사에 따라 적절히 분산하고, 관련있는 컴포넌트 내부로 UI와 로직을 재배치했습니다.
Stat 컴포넌트 리렌더링 개선
Stat.mp4
Stat.mp4
프로필 페이지 리뷰 좋아요 토글 시, 리렌더링 개선
개선 전
개선 후
ContentList.mp4
ContentList.mp4
🔗 관련 이슈
#375
➕ 기타