Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix between_time filtering values #66

Merged
merged 2 commits into from
Jul 31, 2024
Merged

Conversation

maurerle
Copy link
Contributor

Set masked values on parts with indexer_between_time to keep the values not in the time with false.
This is actually unrelated to the mask having an error but comes from between_time returning only a subset of the data, which makes pandas loose the other parts of the index.

fixes #64
supersedes #65

I am not particular happy with this solution, but it includes not having errors and not producing warnings

@pep8speaks
Copy link

Hello @maurerle! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 74:80: E501 line too long (87 > 79 characters)
Line 75:80: E501 line too long (92 > 79 characters)
Line 76:80: E501 line too long (96 > 79 characters)
Line 77:80: E501 line too long (98 > 79 characters)
Line 78:80: E501 line too long (102 > 79 characters)

@p-snft p-snft merged commit cacedb8 into oemof:dev Jul 31, 2024
8 of 9 checks passed
@maurerle maurerle deleted the fix_between_time branch July 31, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants