Revise weather df from era5 #66
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry, it is not good practice to remove the 3.6 support within this PR. I was just to lazy to open an extra one. If you have objections I will revert it. |
birgits
reviewed
Jul 18, 2021
| Extract all coordinates from a er5 netCDf-file and return them as a | ||
| geopandas.Series | ||
| """ | ||
| ds = xr.open_dataset(era5_netcdf_filename) |
There was a problem hiding this comment.
Is it possible to only read longitude and latitude data needed in this function? Would be good for large datasets.
birgits
reviewed
Jul 18, 2021
| `windpowerlib` and `pvlib`. | ||
| drop_coord_levels : bool | ||
| Decide whether the index levels of the coordinates will be dropped. A | ||
| ValueError is raised if there are more than one coordinates. |
There was a problem hiding this comment.
A ValueError is raised if there is more than one coordinate.
birgits
reviewed
Jul 18, 2021
| if np.size(area[0]) == 1 and np.size(area[1]) == 1: | ||
| if drop_coord_levels is True: | ||
| if len(df.groupby(level=[1, 2]).count()) > 1: | ||
| msg = ("You cannot drop the coordinate levels if there are more " |
birgits
approved these changes
Jul 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revise the functions
weather_df_from_era5()and some connected functions:extract_coordinates_from_era5(filename)to get a 'GeoSeries` with all coordinates of the era5-netCDF-file (5aa50ea)shapely.geometrythenearest pointis used instead ofwithinas it was before.The last point does not work, so I added a failing test. See code comment below.-->fixedOne parameter in the function is called area but it can be a point, so I would like to rename it to
geometryorfilteror...