-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revision/storage investment #12
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like your examples and only made two small comments. Maybe you could also explain the outputs in my_results a bit more since I don't find the names self speaking.
my_results = electricity_bus['scalars'] | ||
my_results['storage_invest_GWh'] = results[(storage, None)]['scalars']['invest']/1e6 | ||
my_results['wind_invest_MW'] = results[(wind, bel)]['scalars']['invest']/1e3 | ||
my_results['res_share'] = 1 - results[(pp_gas, bel)]['sequences'].sum()/results[(bel, demand)]['sequences'].sum() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This returns a dataframe where I would only select the flow.
my_results['res_share']['flow']
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
||
Results show a higher renewable energy share than in variation 1 | ||
(78% compared to 51%) due to preinstalled renewable capacities. | ||
Storage is not installed as the gas resource is cheapter. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small typo - cheaper instead of cheapter
I added some variations to the storage investment example and some explanation in the docstring. Therefore I removed the jupyter notebook example (storage_invest) which was basically the same.
The plots are not the same as in the jupyter notebook and the results output could be nicer (also there is storage capacity and power invest mixed in the output in variation 3) --> but I would like to postpone this to another release.