-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for API to add Flows between existing Nodes #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I learned from @gnn (on another channel) that it was already possible to add Flows: node1 = Node()
node2 = Node()
node2.inputs[node1] = Flow()
node1.inputs.update({node2: Flow()}) I think, I will rewrite my tests for that API and document it properly. |
p-snft
changed the title
Provide API to add Flows between existing Nodes
Add tests for API to add Flows between existing Nodes
Oct 6, 2023
As this is just adding tests and I got feedback on other channels, I will probably merge this after adding documentation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an option to add flows between existing nodes in an energy system. However, there was no test, so it could not be considered as part of the API. This PR adds tests to assure the option is there.