Make energy_system.nodes a dict #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The property energy_system.nodes now still contains dict_values. This should be compatible to the old list. Access by label is poosible using energy_system.node[key].
|
I discussed this with @gnn already at the dev meeting. If there are no objections within one week, I will merge. |
p-snft
requested review from
oemof-developer and
a team
and removed request for
oemof-developer
henhuy
requested changes
Dec 14, 2023
The setter is problably unused, and I do not see a test for it. As I do not see a use case, I propose to delete it.
|
The test fails because reporting to Coveralls does not work. |
henhuy
approved these changes
Dec 14, 2023
|
Erm... I actually had an objection and was trying to find the time to push alternative changes instead of raising an objection. That's why the one week objection period was actually important for me. |
|
Sorry, that I implied things that I did not mean to say. As there was an approval, I considered it to be okay. I would have waited for one week if there wasn't an feedback. Still, the changes are not in a published release, so please bring up your alternative. Update: As I learned in the chat, the idea is an API like nodel_labeled_sponk = energy_system.nodes.by_label["sponk"] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Todo:
but we do have them. Another issue might be fixed with Move Node functionality from Entity to Node #30.
Nodes are organised in groupings. This can be done as a separate action.