Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features/csp validation #166

Open
wants to merge 7 commits into
base: dev
Choose a base branch
from
Open

Features/csp validation #166

wants to merge 7 commits into from

Conversation

FranziPl
Copy link
Member

This PR adds the code for the validation of the csp component. To publish the data, we need an approval first.

Copy link
Member

@c-moeller c-moeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we better wait for the approval of the data, so that the file is running. Do you know, if we get this approval for sure and it's just a matter of time?

examples/concentrating_solar_power/validation.py Outdated Show resolved Hide resolved
examples/concentrating_solar_power/validation.py Outdated Show resolved Hide resolved
examples/concentrating_solar_power/validation.py Outdated Show resolved Hide resolved
@FranziPl
Copy link
Member Author

I am not sure, but optimistic.

Co-authored-by: Caroline Möller <[email protected]>
@c-moeller
Copy link
Member

Ok, then let's wait with the merge.

@jnnr jnnr removed their request for review March 10, 2022 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants