Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the fluid property back-end flexible #384

Merged
merged 111 commits into from
Oct 11, 2023

Conversation

fwitte
Copy link
Member

@fwitte fwitte commented Jan 29, 2023

There is a lot of issues with the fluid property back-end that hinder (easy) integration of new features, such as the incompressible mixtures, all sorts of CoolProp inbuilt mixtures and stuff like absorption heat pumps etc.. This PR will make a lot of breaking changes to the current structure but provide an easily adaptable back-end later.

@fwitte fwitte mentioned this pull request May 11, 2023
@fwitte
Copy link
Member Author

fwitte commented Jul 20, 2023

A first small test case is available in the new_fluid_properties_tests.py file:

  • It features a network with two single (non related) connections. The example implementation uses the new fluid_properties module structure.
  • The changes allow to reduce the Jacobian matrix by removing trivial variables from the connections (specified number for mass flow is not a variable).
  • This also removes the need to calculate derivatives towards variables that cannot change their value.
  • The connections class will hold the connections equations in a similar fashion as the components do.

@fwitte
Copy link
Member Author

fwitte commented Oct 11, 2023

Tests now run all, this is completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant