Skip to content

Commit

Permalink
Advertisements support vertical orientations
Browse files Browse the repository at this point in the history
  • Loading branch information
BobChao87 committed Jan 11, 2022
1 parent 3c3e51a commit 240d834
Showing 1 changed file with 10 additions and 2 deletions.
12 changes: 10 additions & 2 deletions components/widget/Advertisement.vue
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ export default Vue.extend({
},
/**
* Shows a small "space" that persists even if the advertisement is not shown
* A "not shown" advertisement can occur due showAdvertisement being false or it not being fulfilled
* A "not shown" advertisement can occur due to showAdvertisement being false or it not being fulfilled
* If the advertisement is fulfilled, there will always be spacers
*/
showSpacer: {
Expand All @@ -46,7 +46,7 @@ export default Vue.extend({
/**
* Flag that is listened to. When it becomes true, a reload will be triggered.
* To trigger additional reloads, it must stop being true before becoming true again.
* XXX Corrently does not reload anything
* XXX Currently does not reload anything
*/
shouldReload: {
type: Boolean,
Expand Down Expand Up @@ -106,10 +106,18 @@ export default Vue.extend({
&.is-horizontal {
margin-block: var(--spacing);
min-height: 50px;
max-height: 100px;
min-width: 300px;
max-width: 728px;
}
&.is-vertical {
margin-inline: var(--spacing);
min-height: 200px;
max-height: 1050px;
min-width: 100px;
max-width: 300px;
}
+ .spacer {
Expand Down

0 comments on commit 240d834

Please sign in to comment.