Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor testing #190

Merged
merged 2 commits into from
Feb 11, 2025
Merged

Refactor testing #190

merged 2 commits into from
Feb 11, 2025

Conversation

oerc0122
Copy link
Owner

@oerc0122 oerc0122 commented Feb 7, 2025

@oerc0122 oerc0122 added the testing Related to test suite. label Feb 7, 2025
@oerc0122 oerc0122 requested a review from ajjackson February 7, 2025 13:37
@oerc0122 oerc0122 self-assigned this Feb 7, 2025
@oerc0122 oerc0122 force-pushed the refactor-testing branch 7 times, most recently from 8207530 to acbf9f5 Compare February 7, 2025 14:08
@oerc0122
Refactor testing
acbf9f5 
- Migrate to pytest testing
- Move tests out of main folder
- Add coverage reporting to github
- Add testing for pyyaml
- Refactor how ruamel vs pyyaml is implemented
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 7, 2025 •
edited
Loading

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
2897 2667 92% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
castep_outputs/utilities/dumpers.py 82% 🟢
TOTAL 82% 🟢

updated for commit: 3d02d65 by action🐍

ajjackson
ajjackson reviewed Feb 11, 2025
View reviewed changes
Copy link
Collaborator

@ajjackson ajjackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well this took a lot less time to look at than the diff suggested 😆

test/test_dumpers.py Show resolved Hide resolved
test/test_dumpers.py Outdated Show resolved Hide resolved
test/test_filters.py Show resolved Hide resolved
ajjackson
ajjackson approved these changes Feb 11, 2025
View reviewed changes
Copy link
Collaborator

@ajjackson ajjackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All seems pretty sensible and useful.

I note that the ruamel format is much nicer to look at!

I'll also be interested to see how things go with this non-intrusive coverage action. Maybe some other projects can use it...

@oerc0122 oerc0122 merged commit f7e2e6d into main Feb 11, 2025
5 checks passed
@oerc0122 oerc0122 deleted the refactor-testing branch February 11, 2025 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajjackson ajjackson ajjackson approved these changes

Assignees

@oerc0122 oerc0122

Labels
testing Related to test suite.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move testing over to pytest test_dumper passes with ruamel.yaml but not pyyaml
2 participants
@oerc0122 @ajjackson