-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix cutechess command #2117
base: master
Are you sure you want to change the base?
fix cutechess command #2117
Conversation
updated the SHA |
One question is if this affects other stuff like the seed?, how the book is picked from, and other stuff. |
i will run a side by side fixed nodes test and upload the pgns here, it should result to be the same |
new format:
old format:
|
newformat.pgn.txt as can be seen, the resulting pgns are exactly identical except now with the new format the |
looks good to me. |
I don't think it was me who first noticed this.. maybe david or someone else, but w/e |
cutechess command in games.py is incorrectly formatted causing a bug where the pgn have all games with the tag
["Round 1"]
. this is first spotted by @Disservinthis change is also necessary for an eventual fast-chess migration as fast-chess relies on the correct format.