Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add formatting #277

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Disservin
Copy link
Member

@Sopel97 what do you say about adding some formatters?

black is also used for the wdl repo https://github.com/official-stockfish/WDL_model/tree/master, and the clang-format is taken from stockfish master

@Sopel97
Copy link
Member

Sopel97 commented Mar 17, 2024

if we can get it to agree whether strings should be '' or "" I'm fine with it

@Disservin
Copy link
Member Author

It uses double quotes " but some strings have double quotes inside them and use the opposite quotation characters. I.e.
print('root_dir - the directory to "cleanup"'), this isn't automatically converted into a double quote because it'd need escaping.

@vondele
Copy link
Member

vondele commented Apr 30, 2024

I would also add a formatter, so if this can be rebased, let's merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants