Add Serde support behind feature flag #5
Conversation
|
Thanks for your pull request, I'll review it and merge it asap! |
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
|
@ofmooseandmen , Please let me know if there is anything else you would like me to do for this guy, it wasn't apparent to me how to get it to ignore the derive lines for code coverage, but I can try to figure that out. |
|
@zheylmun, sorry I was quite busy lately, if you could find a way to get the code coverage that would be great. Otherwise, I'll merge by-passing the checks. |
|
As soon as I said this I found a way to do it with comments |
zheylmun
force-pushed
the
feature/serde_support
branch
from
46ccfc4
to
5ffc83d
Compare
|
@zheylmun, you'll need to run the formatter (clippy is not happy...) |
|
@ofmooseandmen, I manually ran all of the CI commands and think this is good to go, but lemme know if you'd like anything else changed |
|
Thanks @zheylmun for your contribution and sorry it took me so long to merge |
Hello! Thanks for putting together such a fantastic library. I'm doing some experimental work on improved tooling for underwater cave survey, and Jord does much of what I need other than serializing data types. I added serialization for each struct and enum, and the changes are behind a serde feature flag, so there are no additional dependencies unless someone enables the feature.
Additionally I did switch the crate level lint from forbid to deny. Forbid was giving a false positive for unused crates, and is being replaced anyways:
rust-lang/rust#81670