Fix resource request #9935

bodhish · 2025-01-13T11:06:15Z

Proposed Changes

This pull request includes updates to localization strings and refactors the facility API integration. The most important changes include adding new localization entries, modifying existing entries for consistency, and refactoring the API calls for facility data.

Localization updates:

public/locale/en.json: Added new entries such as "basic_information", "category_description", "contact_information_description", "emergency_description", "facility_for_care_support", "file_upload_error", "file_upload_success", "request_reason_description", "request_title_description", and "select_facility_description". Modified existing entries for consistency, such as "is_this_an_emergency" and "password_length_met". [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11]

API refactoring:

src/Utils/request/api.tsx: Removed the getAllFacilities route.
src/components/Common/FacilitySelect.tsx: Replaced the old API route with the new facilityApi.getAllFacilities and removed unnecessary parameters. [1] [2] [3] [4]
src/pages/Facility/FacilitiesPage.tsx: Updated the API call to use facilityApi.getAllFacilities and replaced FacilityModel with FacilityData. [1] [2]
src/pages/Facility/components/FacilityCard.tsx: Replaced FacilityModel with FacilityData.
src/pages/Facility/hooks/useFacilityQueries.ts: Removed the useFacilityQueries hook that used the old API route.
src/types/facility/facility.ts: Made phone_number and pincode fields required in the FacilityData interface.
src/types/facility/facilityApi.ts: Added a new API definition for getAllFacilities.
@ohcnetwork/care-fe-code-reviewers

Merge Checklist

Add specs that demonstrate bug / test a new feature.
Update product documentation.
Ensure that UI text is kept in I18n files.
Prep screenshot or demo video for changelog entry, and attach it to issue.
Request for Peer Reviews
Completion of QA

Summary by CodeRabbit

New Features
- Enhanced localization with more descriptive labels and instructions for resource requests
- Improved form validation and user guidance in resource creation process
Bug Fixes
- Refined facility data handling and API interactions
- Updated facility data type requirements
Documentation
- Added clearer descriptions for form fields and user interactions
Refactor
- Streamlined facility selection and resource creation components
- Updated API endpoint and data model for facility management

coderabbitai · 2025-01-13T11:06:25Z

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request introduces comprehensive changes across multiple files, focusing on enhancing the localization, facility management, and resource request functionality. The modifications include updating the English locale JSON with new descriptive keys, removing the getAllFacilities endpoint, refactoring the ResourceCreate component to use react-hook-form, and updating facility-related data models and types. The changes aim to improve form validation, API interactions, and overall user experience in the application.

Changes

File	Change Summary
`public/locale/en.json`	Added multiple new descriptive keys for resource requests, contact information, and file upload statuses
`src/Utils/request/api.tsx`	Removed `getAllFacilities` endpoint
`src/components/Common/FacilitySelect.tsx`	Removed `district` and `state` parameters, updated API request logic
`src/components/Resource/ResourceCreate.tsx`	Replaced `useReducer` with `react-hook-form`, added Zod validation, updated form structure
`src/pages/Facility/FacilitiesPage.tsx`	Updated data model from `FacilityModel` to `FacilityData`, changed API function
`src/pages/Facility/components/FacilityCard.tsx`	Updated `facility` prop type from `FacilityModel` to `FacilityData`
`src/types/facility/facility.ts`	Made `phone_number` and `pincode` required in `FacilityData` interface
`src/types/facility/facilityApi.ts`	Added new `getAllFacilities` API endpoint configuration

Possibly related PRs

Fix: Allergy count to Updated to has allergies text #9399: Adds new keys to localization file for resource requests
Patient Registration form refactor #9854: Modifies localization file for form validation messages
Care Loading icon in organization and facility users #9723: Enhances loading indicators in facility-related components

Suggested Labels

tested, reviewed

Suggested Reviewers

rithviknishad

Poem

🐰 Hopping through code with glee,
Locales and types now set free!
Forms dance with Zod's embrace,
Facilities find their new space,
A rabbit's refactor, clean and light! 🌟

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b8f25c2 and 8fa56a1.

📒 Files selected for processing (9)

public/locale/en.json (12 hunks)
src/Utils/request/api.tsx (0 hunks)
src/components/Common/FacilitySelect.tsx (3 hunks)
src/components/Resource/ResourceCreate.tsx (4 hunks)
src/pages/Facility/FacilitiesPage.tsx (2 hunks)
src/pages/Facility/components/FacilityCard.tsx (1 hunks)
src/pages/Facility/hooks/useFacilityQueries.ts (0 hunks)
src/types/facility/facility.ts (1 hunks)
src/types/facility/facilityApi.ts (1 hunks)

Finishing Touches

📝 Generate Docstrings (Beta)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

netlify · 2025-01-13T11:06:34Z

✅ Deploy Preview for care-ohc ready!

Name	Link
🔨 Latest commit	`8fa56a1`
🔍 Latest deploy log	https://app.netlify.com/sites/care-ohc/deploys/6784f3aa22fe1f0008afca20
😎 Deploy Preview	https://deploy-preview-9935--care-ohc.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

cloudflare-workers-and-pages · 2025-01-13T11:07:52Z

Deploying care-fe with Cloudflare Pages

Latest commit:	`8fa56a1`
Status:	✅ Deploy successful!
Preview URL:	https://a80209b6.care-fe.pages.dev
Branch Preview URL:	https://resource-request-fix.care-fe.pages.dev

View logs

github-actions · 2025-01-13T11:08:05Z

@bodhish Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Fix resource request

8fa56a1

bodhish requested a review from a team as a code owner January 13, 2025 11:06

bodhish merged commit a47edbf into develop Jan 13, 2025
18 of 19 checks passed

bodhish deleted the resource-request-fix branch January 13, 2025 11:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix resource request #9935

Fix resource request #9935

bodhish commented Jan 13, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jan 13, 2025 •

edited

Loading

Review failed

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

netlify bot commented Jan 13, 2025 •

edited

Loading

cloudflare-workers-and-pages bot commented Jan 13, 2025

github-actions bot commented Jan 13, 2025

Fix resource request #9935

Fix resource request #9935

Conversation

bodhish commented Jan 13, 2025 • edited by coderabbitai bot Loading

Proposed Changes

Merge Checklist

Summary by CodeRabbit

coderabbitai bot commented Jan 13, 2025 • edited Loading

Review failed

Walkthrough

Changes

Possibly related PRs

Suggested Labels

Suggested Reviewers

Poem

Finishing Touches

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

netlify bot commented Jan 13, 2025 • edited Loading

✅ Deploy Preview for care-ohc ready!

cloudflare-workers-and-pages bot commented Jan 13, 2025

Deploying care-fe with Cloudflare Pages

github-actions bot commented Jan 13, 2025

bodhish commented Jan 13, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jan 13, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

netlify bot commented Jan 13, 2025 •

edited

Loading