OTP appointment reschedule #9974
Conversation
Jacobjeevan
added
the
waiting for related PR
WalkthroughThis pull request introduces changes across multiple files to support appointment rescheduling functionality and update import paths. The modifications include adding a new route for rescheduling appointments, implementing a rescheduling mechanism in the Schedule and AppointmentDialog components, updating localization strings, and standardizing import statements using the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
✅ Deploy Preview for care-ohc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
👋 Hi, @Jacobjeevan, This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there. |
rithviknishad
removed
the
waiting for related PR
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (7)
cypress/e2e/facility_spec/facility_creation.cy.ts(1 hunks)cypress/e2e/patient_spec/patient_creation.cy.ts(1 hunks)public/locale/en.json(1 hunks)src/Routers/PatientRouter.tsx(1 hunks)src/pages/Patient/components/AppointmentDialog.tsx(3 hunks)src/pages/PublicAppointments/Schedule.tsx(10 hunks)src/types/facility/facility.ts(1 hunks)
✅ Files skipped from review due to trivial changes (3)
- src/types/facility/facility.ts
- cypress/e2e/patient_spec/patient_creation.cy.ts
- cypress/e2e/facility_spec/facility_creation.cy.ts
🔇 Additional comments (9)
src/pages/PublicAppointments/Schedule.tsx (4)
1-2: Imports added correctly for new functionalitiesThe import statements for
useMutation,useQuery,useQueryClient, and date-fns functions (format,isBefore,isSameDay) are necessary and correctly added to support the new appointment rescheduling functionalities.
40-40: AddedappointmentIdprop toAppointmentsPropsinterfaceThe addition of the optional
appointmentIdprop in theAppointmentsPropsinterface allows the component to handle both booking and rescheduling of appointments effectively.
64-83: Ensure proper handling of sensitive appointment dataFetching appointment data using
useQueryis appropriate for rescheduling functionality. However, please verify that any sensitive patient information withinappointmentDatais handled securely and complies with privacy regulations.
368-379: Verify thatselectedSlotis defined before reschedulingWhen handling the reschedule action, ensure that
selectedSlotis selected by the user before attempting to create a new appointment. IfselectedSlotis undefined, it may cause errors during appointment creation.Consider adding a check before calling
handleRescheduleAppointment:if (appointmentId && appointment) { + if (selectedSlot) { handleRescheduleAppointment(appointment); + } else { + toast.error(t("please_select_a_slot")); + } } else { // existing code }src/Routers/PatientRouter.tsx (1)
50-64: Reschedule route added correctlyThe new route for rescheduling appointments is properly added to
AppointmentRoutes. The route parameters are correctly defined, and theScheduleAppointmentcomponent receives all necessary props for rescheduling functionality.src/pages/Patient/components/AppointmentDialog.tsx (3)
2-2: ImportednavigatefromravigerThe import statement for
navigatefromravigeris correctly added to enable navigation within the appointment dialog.
43-47: FunctionhandleRescheduleAppointmentimplemented correctlyThe
handleRescheduleAppointmentfunction constructs the correct URL for navigating to the reschedule appointment page using the appointment details.
112-115: Reschedule button added with correct functionalityThe "Reschedule" button is appropriately added to the dialog footer and correctly calls
handleRescheduleAppointmenton click, enabling users to initiate the rescheduling process.public/locale/en.json (1)
1773-1773: LGTM! The new localization string is well-formatted.The added key-value pair follows the established naming conventions and is properly placed in alphabetical order. The text is appropriately capitalized and grammatically correct.
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (3)
src/pages/PublicAppointments/Schedule.tsx (3)
79-83: Add cleanup to the appointment reason effect.The effect that sets the reason should clean up its changes when the component unmounts or when the appointment changes.
useEffect(() => { if (appointment) { setReason(appointment.reason_for_visit); } + return () => { + setReason(""); + }; }, [appointment]);
169-178: Consider using a transaction or optimistic updates for reschedule flow.The current implementation has a potential race condition where the cancellation succeeds but the creation fails. While global error handling is in place, consider using optimistic updates to improve the user experience during the delay between cancel and create operations.
onSuccess: (appointment: Appointment) => { toast.success(t("appointment_cancelled")); + // Optimistically update the UI + queryClient.setQueryData( + ["appointment", tokenData.phoneNumber], + (old: { results: Appointment[] } | undefined) => ({ + results: old?.results.filter((a) => a.id !== appointment.id) || [], + }) + ); queryClient.invalidateQueries({ queryKey: ["appointment", tokenData.phoneNumber], }); createAppointment({ reason_for_visit: reason, patient: appointment.patient.id, }); },
375-379: Consider session storage for temporary data.While the stored data isn't sensitive (as confirmed in past reviews), consider using
sessionStorageinstead oflocalStoragefor temporary data that's only needed during the booking flow.-localStorage.setItem( +sessionStorage.setItem( "selectedSlot", JSON.stringify(selectedSlot), ); -localStorage.setItem( +sessionStorage.setItem( "reason", reason );
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/pages/PublicAppointments/Schedule.tsx(10 hunks)
🔇 Additional comments (1)
src/pages/PublicAppointments/Schedule.tsx (1)
365-367: Good use of loading indicators!The loading state handling addresses the delay mentioned in the PR objectives, providing clear feedback to users during the reschedule operation.
|
@Jacobjeevan Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌 |
Co-authored-by: rithviknishad <[email protected]>
Proposed Changes
@ohcnetwork/care-fe-code-reviewers
Merge Checklist
Summary by CodeRabbit
Release Notes
New Features
Localization
Improvements
Chores