Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Primary feature images visibility #46

Conversation

Mahendar0701
Copy link
Contributor

@Mahendar0701 Mahendar0701 commented Dec 31, 2024

Fixes : #45

Previous:

Image

Updated:

image

Copy link

netlify bot commented Dec 31, 2024

Deploy Preview for landing-ohc ready!

Name Link
🔨 Latest commit 3e03738
🔍 Latest deploy log https://app.netlify.com/sites/landing-ohc/deploys/678377839227bb0008034e08
😎 Deploy Preview https://deploy-preview-46--landing-ohc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Mahendar0701 Mahendar0701 changed the title Update Primary features images visibility Update Primary feature images visibility Jan 3, 2025
Copy link
Member

@shivankacker shivankacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Mahendar0701 lgtm, can we move to tsx?

@Mahendar0701
Copy link
Contributor Author

@Mahendar0701 lgtm, can we move to tsx?

@shivankacker

Yeah i will update and also bodhish suggested to add swiping feature for images in mobile view. Can i use react-swipeable library for that or will you recommend any other library?

@Mahendar0701
Copy link
Contributor Author

@Mahendar0701 lgtm, can we move to tsx?

@shivankacker

Yeah i will update and also bodhish suggested to add swiping feature for images in mobile view on slack comment. Can i use react-swipeable library for that or will you recommend any other library?

@shivankacker
Copy link
Member

@Mahendar0701 no need for libraries, try scroll-snap
https://tailwindcss.com/docs/scroll-snap-align

Scroll would auto change to swipe on mobile.

@rithviknishad rithviknishad merged commit eb7ca3c into ohcnetwork:main Jan 14, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Primary Features images not fully visible
3 participants