Skip to content

Commit

Permalink
🌍 Update JSON - 19 Nov 2023 | 07:29 AM
Browse files Browse the repository at this point in the history
  • Loading branch information
mathew-alex committed Nov 19, 2023
1 parent 0fc2253 commit 78ae0fe
Show file tree
Hide file tree
Showing 5 changed files with 57 additions and 14 deletions.
18 changes: 16 additions & 2 deletions data/github/ayush-seth.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,20 @@
{
"last_updated": 1700239006.0,
"last_updated": 1700301288.0,
"activity": [
{
"type": "comment_created",
"title": "coronasafe/care_fe#6665",
"time": 1700301288.0,
"link": "https://github.com/coronasafe/care_fe/issues/6665#issuecomment-1817463174",
"text": "This is a bigger problem at its core with how route protection and login is being handled and just replacing `window.location.href =` with `navigate()` is not going to solve these issues. \r\n\r\nFor ex. when I am logged out and I navigate to `/shifting/board`, instead of being redirected to `/login` I stay on `/shifting/board` and in those cases, after logging in, it does `window.location.href = window.location.pathname.toString()`, using `navigate` here won't do anything because the path does not change, you have to reload the whole page. Same goes for any other url."
},
{
"type": "comment_created",
"title": "coronasafe/care_fe#6665",
"time": 1700300406.0,
"link": "https://github.com/coronasafe/care_fe/issues/6665#issuecomment-1817458427",
"text": "Any reason this project is using [raviger](https://github.com/kyeotic/raviger) which barely anyone has ever heard of and has not been updated since 2022 instead of using the industry standard [React Router](https://github.com/remix-run/react-router)?"
},
{
"type": "comment_created",
"title": "coronasafe/care_fe#6503",
Expand Down Expand Up @@ -41,7 +55,7 @@
{
"link": "https://github.com/coronasafe/care_fe/pull/6663",
"title": "show delete user button only for stateAdmin",
"stale_for": 0,
"stale_for": 1,
"labels": [
"needs testing"
]
Expand Down
9 changes: 8 additions & 1 deletion data/github/nihal467.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,13 @@
{
"last_updated": 1700135059.0,
"last_updated": 1700318591.0,
"activity": [
{
"type": "comment_created",
"title": "coronasafe/care_fe#6650",
"time": 1700318591.0,
"link": "https://github.com/coronasafe/care_fe/issues/6650#issuecomment-1817526924",
"text": "@konavivekramakrishna use the login :\r\nusername ;nihal-district / Password : Test@123\r\n"
},
{
"type": "comment_created",
"title": "coronasafe/care_fe#6655",
Expand Down
24 changes: 19 additions & 5 deletions data/github/rithviknishad.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,20 @@
{
"last_updated": 1700239764.0,
"last_updated": 1700330752.0,
"activity": [
{
"type": "comment_created",
"title": "coronasafe/care_fe#6650",
"time": 1700330752.0,
"link": "https://github.com/coronasafe/care_fe/issues/6650#issuecomment-1817585406",
"text": "@konavivekramakrishna The API has responded with 202 Accepted. Hence no errors were encountered. Have you tried calling the list API for the same after a successful upsert?"
},
{
"type": "comment_created",
"title": "coronasafe/care_fe#6665",
"time": 1700303828.0,
"link": "https://github.com/coronasafe/care_fe/issues/6665#issuecomment-1817472008",
"text": "I don't see any issue with Raviger's routing.\r\n\r\nIf you look at the code, we have two routers: Session and App router. App router is accessible only if the query to get the current profile responds with 200, you'll be exposed to the App router, else it'll show the Session router.\r\n\r\nWe just need to invoke the refetch of the current user query somehow whenever the JWT access token is updated in the local storage. That'd cause the AuthUserProvider component to render, and hence exposing the appropriate router based on the response.\r\n\r\n<img width=\"566\" alt=\"image\" src=\"https://github.com/coronasafe/care_fe/assets/25143503/6c5c9540-0d5a-4edf-879c-6e183eb0c73a\">\r\n\r\n<img width=\"691\" alt=\"image\" src=\"https://github.com/coronasafe/care_fe/assets/25143503/f180b3cb-c646-4c7e-af9c-b35e8b0af0c0\">\r\n\r\n"
},
{
"type": "issue_opened",
"title": "coronasafe/care_fe#6665",
Expand Down Expand Up @@ -27151,15 +27165,15 @@
{
"link": "https://github.com/coronasafe/care/pull/1704",
"title": "Adds authz for Prescription & Medicine Administrations",
"stale_for": 3,
"stale_for": 4,
"labels": [
"waiting-for-review"
]
},
{
"link": "https://github.com/coronasafe/care_fe/pull/6464",
"title": "Adds user type: Nurse and Nurse (readonly)",
"stale_for": 3,
"stale_for": 4,
"labels": [
"changes required",
"waiting for back end"
Expand All @@ -27168,15 +27182,15 @@
{
"link": "https://github.com/coronasafe/care/pull/1678",
"title": "Patient Consultation: Route to Facility \ud83c\udfe5, Admission Date & Time \ud83d\udd5a, Rename variable: `verified_by` to `treating_physician`",
"stale_for": 3,
"stale_for": 4,
"labels": [
"waiting-for-review"
]
},
{
"link": "https://github.com/coronasafe/care_fe/pull/6458",
"title": "Patient Consultation: Route to Facility \ud83c\udfe5, Admission Date & Time \ud83d\udd5a",
"stale_for": 3,
"stale_for": 4,
"labels": [
"Backend",
"tested",
Expand Down
17 changes: 12 additions & 5 deletions data/github/shyamprakash123.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,13 @@
{
"last_updated": 1700234724.0,
"last_updated": 1700270740.0,
"activity": [
{
"type": "comment_created",
"title": "coronasafe/care_fe#6608",
"time": 1700270740.0,
"link": "https://github.com/coronasafe/care_fe/issues/6608#issuecomment-1817309126",
"text": "> Which user can delete is already present in the code base. The issue is about hiding the button instead of keeping it disabled.\r\n> \r\n> <img alt=\"image\" width=\"474\" src=\"https://user-images.githubusercontent.com/25143503/283868574-dd2083b1-8996-4ecf-b883-83acdadbe4e8.png\">\r\n\r\nUnderstood, please assign me so that I can start working on this."
},
{
"type": "comment_created",
"title": "coronasafe/care_fe#6608",
Expand Down Expand Up @@ -444,15 +451,15 @@
{
"link": "https://github.com/coronasafe/care_fe/pull/6662",
"title": "Removed mandatory for Rhythm field",
"stale_for": 0,
"stale_for": 1,
"labels": [
"needs testing"
]
},
{
"link": "https://github.com/coronasafe/care_fe/pull/6578",
"title": "\ud83e\ude9b Fixed Non-uniform height of Asset List Tiles.",
"stale_for": 0,
"stale_for": 1,
"labels": [
"tested",
"good to merge"
Expand All @@ -461,15 +468,15 @@
{
"link": "https://github.com/coronasafe/care_fe/pull/6576",
"title": "\u2714\ufe0f Fixed reloading issue while Opening Investigations or Treatment Summary in Consultation Dashboard.",
"stale_for": 0,
"stale_for": 1,
"labels": [
"needs testing"
]
},
{
"link": "https://github.com/coronasafe/care_fe/pull/6574",
"title": "\ud83d\ude80 Improved info of vitals monitor in mobile view.",
"stale_for": 0,
"stale_for": 1,
"labels": [
"tested",
"good to merge"
Expand Down
3 changes: 2 additions & 1 deletion data/slack/message_dump.json
Original file line number Diff line number Diff line change
Expand Up @@ -93632,5 +93632,6 @@
]
}
],
"2023-11-18 00:00:00": []
"2023-11-18 00:00:00": [],
"2023-11-19 00:00:00": []
}

1 comment on commit 78ae0fe

@vercel
Copy link

@vercel vercel bot commented on 78ae0fe Nov 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.