Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate PR collaboration activities #531

Closed
rithviknishad opened this issue Oct 22, 2024 · 9 comments · Fixed by #534
Closed

Duplicate PR collaboration activities #531

rithviknishad opened this issue Oct 22, 2024 · 9 comments · Fixed by #534
Assignees
Labels

Comments

@rithviknishad
Copy link
Member

Currently activities such as "PR collaboration" may get duplicated when the default branch gets merged to another branch such as production/staging. This misjudges collaboration activities.

Proposed Solution

  • Exclude PR activities where the base branch is the non-default branch of the repository.

Image

cc: @bodhish

@VAIBHAVSING
Copy link
Contributor

/assign

@VAIBHAVSING
Copy link
Contributor

@rithviknishad can you describe this issue in berif

@rithviknishad
Copy link
Member Author

PR collaboration events should be tracked only for if the PR's base branch is the repository default branch

appendEvent(user, {
type: "pr_collaborated",
title: `${event.repo.name}#${event.payload.pull_request.number}`,
time: eventTime.toISOString(),
link: event.payload.pull_request.html_url,
text: event.payload.pull_request.title,
collaborated_with: [...othersArray],
});

@VAIBHAVSING
Copy link
Contributor

@rithviknishad hello sir ,
I will not able to run scrapper can you assign to another person please.

@rithviknishad
Copy link
Member Author

Are you facing any difficulties running the scraper?

@VAIBHAVSING
Copy link
Contributor

@rithviknishad i will not able run scrapper after pasting github token in that
Image

@rithviknishad
Copy link
Member Author

here's the command to run the scraper

GITHUB_TOKEN=$(gh auth token) pnpm dev ohcnetwork ../data-repo/data/github

@VAIBHAVSING
Copy link
Contributor

@rithviknishad can i completely ignore merge request from stagging or production branch or only ignore in above provided code at addcollaboration

VAIBHAVSING added a commit to VAIBHAVSING/OHcnetwork-leaderboard that referenced this issue Oct 29, 2024
@rithviknishad
Copy link
Member Author

Didn't understand that, but whatever that was done in the PR is right.

VAIBHAVSING added a commit to VAIBHAVSING/OHcnetwork-leaderboard that referenced this issue Oct 30, 2024
@rithviknishad rithviknishad linked a pull request Oct 30, 2024 that will close this issue
rithviknishad added a commit that referenced this issue Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants