feat :Duplicate PR collaboration activities closes #531 #534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for leaderboard-develop ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
rithviknishad
requested changes
Oct 30, 2024
Comment on lines
12
to
24
| async function fetchdefaultbranch(org: string, repo: string) { | ||
| try { | ||
| const { data } = await octokit.request('GET /repos/{owner}/{repo}', { | ||
| owner: org, | ||
| repo: repo, | ||
| }); | ||
| return data.default_branch; | ||
| } catch (e) { | ||
| console.error( | ||
| `Error fetching default branch for organisation ${org} /${repo} `, | ||
| ); | ||
| } | ||
| } |
There was a problem hiding this comment.
Can we maintain a cache of the results? So that we don't need to keep hitting GitHub's APIs for every PRs that collaboration event is to be added?
Comment on lines
119
to
136
| if (collaborators.size > 1) { | ||
| const collaboratorArray = Array.from(collaborators); // Convert Set to Array | ||
| for (const user of collaboratorArray) { | ||
| const others = new Set(collaborators); | ||
| const othersArray = Array.from(others); | ||
|
|
||
| others.delete(user); | ||
| appendEvent(user, { | ||
| type: "pr_collaborated", | ||
| title: `${event.repo.name}#${event.payload.pull_request.number}`, | ||
| time: eventTime.toISOString(), | ||
| link: event.payload.pull_request.html_url, | ||
| text: event.payload.pull_request.title, | ||
| collaborated_with: [...othersArray], | ||
| }); | ||
| if (event.payload.pull_request.base.ref === default_branch) { | ||
| for (const user of collaboratorArray) { | ||
| const others = new Set(collaborators); | ||
| const othersArray = Array.from(others); | ||
|
|
||
| others.delete(user); | ||
|
|
||
| appendEvent(user, { | ||
| type: "pr_collaborated", | ||
| title: `${event.repo.name}#${event.payload.pull_request.number}`, | ||
| time: eventTime.toISOString(), | ||
| link: event.payload.pull_request.html_url, | ||
| text: event.payload.pull_request.title, | ||
| collaborated_with: [...othersArray], | ||
| }); | ||
| } |
There was a problem hiding this comment.
the check can be merged along with line before like if (collaborators.size > 1 && event.payload... === default branch right?
scraper/src/github-scraper/types.ts
Outdated
| @@ -15,6 +15,7 @@ interface Comment { | |||
| } | |||
|
|
|||
| export interface PullRequest { | |||
| base: any; | |||
There was a problem hiding this comment.
add proper types; any is not allowed.
VAIBHAVSING
changed the title
VAIBHAVSING
commented
Oct 30, 2024
rithviknishad
requested changes
Oct 30, 2024
Comment on lines
12
to
22
| const DefaultBranch = new Map<string, string>(); | ||
| async function getDefaultBranch(org: string, repo: string) { | ||
| try { | ||
| if (DefaultBranch.has(`${org}/${repo}`)) { | ||
| return DefaultBranch.get(`${org}/${repo}`); | ||
| } | ||
| const { data } = await octokit.request('GET /repos/{owner}/{repo}', { | ||
| owner: org, | ||
| repo: repo, | ||
| }); | ||
| return data.default_branch; |
There was a problem hiding this comment.
what's the use of the cache when we are not setting anything to the cache ever?
rithviknishad
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
here before changes this issue persist at url: http://localhost:3000/contributors/gigincg
after changes