Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter feeds #427

Closed
wants to merge 18 commits into from
Closed

Filter feeds #427

wants to merge 18 commits into from

Conversation

dgparmar14
Copy link
Contributor

@dgparmar14 dgparmar14 commented Apr 8, 2024

Description

There is a need for a filter on the feed page.
This PR introduces a feature to implement filters based on repositories and events.

Fixes #424

Type of change

  1. Created a GithubFeed.tsx component to utilize useState for applying filters.

Example

image

Copy link

vercel bot commented Apr 8, 2024

@dgparmar14 is attempting to deploy a commit to the Open Healthcare Network Team on Vercel.

A member of the Team first needs to authorize it.

@dgparmar14
Copy link
Contributor Author

@rithviknishad Please review this pr to close the issue.

app/api/leaderboard/functions.ts Outdated Show resolved Hide resolved
app/api/leaderboard/functions.ts Outdated Show resolved Hide resolved
app/api/leaderboard/functions.ts Outdated Show resolved Hide resolved
app/feed/page.tsx Outdated Show resolved Hide resolved
app/feed/page.tsx Outdated Show resolved Hide resolved
components/gh_events/GithubFeed.tsx Outdated Show resolved Hide resolved
components/gh_events/GithubFeed.tsx Outdated Show resolved Hide resolved
app/api/leaderboard/functions.ts Outdated Show resolved Hide resolved
app/api/leaderboard/functions.ts Outdated Show resolved Hide resolved
app/api/leaderboard/functions.ts Outdated Show resolved Hide resolved
app/feed/page.tsx Outdated Show resolved Hide resolved
app/feed/page.tsx Outdated Show resolved Hide resolved
app/feed/page.tsx Outdated Show resolved Hide resolved
app/feed/page.tsx Outdated Show resolved Hide resolved
app/leaderboard/_components/Searchbar.tsx Outdated Show resolved Hide resolved
app/feed/page.tsx Outdated Show resolved Hide resolved
components/gh_events/GithubFeedFilter.tsx Outdated Show resolved Hide resolved
app/api/leaderboard/functions.ts Outdated Show resolved Hide resolved
app/api/leaderboard/functions.ts Outdated Show resolved Hide resolved
app/api/leaderboard/functions.ts Outdated Show resolved Hide resolved
rithviknishad
rithviknishad previously approved these changes Apr 19, 2024
Copy link

vercel bot commented Apr 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
leaderboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 25, 2024 10:35am

Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. It takes a lot of time for the page to navigate once the filter state has been changed. Let's show a loading animation.

  2. The event names are not formatted to be readable.

image
  1. Let's make this an autocomplete field instead as there is a lot of repositories listed here. Also sort by last updated date.
image

@rithviknishad
Copy link
Member

@dgparmar14 any updates on this? Let's ship this out ASAP 😄

@dgparmar14 dgparmar14 requested a review from rithviknishad May 3, 2024 17:46
@dgparmar14
Copy link
Contributor Author

dgparmar14 commented May 3, 2024

@rithviknishad Hey, I did not get ideas on how to make loading can you suggest better idea to add loading?

@dgparmar14
Copy link
Contributor Author

@rithviknishad It's not done yet bro

@rithviknishad
Copy link
Member

@dgparmar14 any updates on this?

@rithviknishad
Copy link
Member

@dgparmar14 Closing as inactive, feel free to re-open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FIlter Events In Feed Page
2 participants