-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: fetch events for bots #555
Fix: fetch events for bots #555
Conversation
👷 Deploy request for leaderboard-develop pending review.Visit the deploys page to approve it
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @rithviknishad, I don’t think this issue is coming from this piece of code. There seems to be something else causing it. |
You're right. But from where else it should come? 🤔 |
Looks like only PR Merged events are there. And I had merged dependabot's PRs that day. So even though I was the one who merged it, the author of the PR is still dependabot. So likely some incorrect logic there maybe? The Author of the PR should get the event and not the one who merged it. leaderboard/scraper/src/github-scraper/parseEvents.ts Lines 204 to 211 in be46e0b
|
Let me check @rithviknishad, Am I understanding it wrong? It is okay na if the author is dependabot for its PRs.
|
inactive |
Proposed Changes
Fix: #554
Reviewer(s)
@rithviknishad