83 overhaul modals #142
Merged
83 overhaul modals #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tried a lot of different approaches and various Svelte tooltip/popover libraries to address #83, but none quite worked as well as I needed. Ultimately, copy-pasted this repl example to make a local modal component.
It can be triggered with any click (important for mobile compatibility) so it is currently implemented with info buttons in the volume summary page like so
Closes #83, though there are plenty more places now that this info modal could be implemented, especially in the georeferencing and split interfaces.
Also fixed some date parsing to close #140, I think the LOC date tags may have gone from 1889-01 to 1889-01-01 or something.