fixed Shesmu case status prematurely marked complete (#44)

oicr-gsi · Feb 28, 2024 · 10454c2 · 10454c2
1 parent 77939ec
commit 10454c2
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/cardea-server/src/main/java/ca/on/oicr/gsi/cardea/server/service/CaseService.java b/cardea-server/src/main/java/ca/on/oicr/gsi/cardea/server/service/CaseService.java
@@ -98,8 +98,9 @@ private int getRefreshFailures() {
   private CaseStatus getCaseStatus(Case kase) {
     if (kase.isStopped()) {
       return CaseStatus.STOPPED;
-    } else if (kase.getDeliverables().stream().anyMatch(
-        deliverable -> deliverable.getReleases().stream().anyMatch(CaseRelease::getQcPassed))) {
+    } else if (!kase.getDeliverables().isEmpty() && kase.getDeliverables().stream()
+        .allMatch(deliverable -> deliverable.getReleases().stream()
+            .allMatch(release -> Boolean.TRUE.equals(release.getQcPassed())))) {
       return CaseStatus.COMPLETED;
     } else {
       return CaseStatus.ACTIVE;