Skip to content

Commit

Permalink
Grammar fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
avarsava committed May 10, 2024
1 parent 2ea53ac commit 8b425c7
Show file tree
Hide file tree
Showing 6 changed files with 9 additions and 9 deletions.
4 changes: 2 additions & 2 deletions design.md
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ The goal for Víðarr web service is to:

## Shesmu Integration
Shesmu needs file provenance and can use Cerberus as a plugin. Shesmu also
needs run workflows and can use the `/api/submit` endpoint for that purpose. It
needs to run workflows and can use the `/api/submit` endpoint for that purpose. It
needs to know what it can run and uses `/api/workflows` to get the known
workflow and `/api/targets` to know where it can run them; it generates an
action definition for every valid workflow version and target combination. The
Expand Down Expand Up @@ -83,7 +83,7 @@ Once received:
Once a workflow is started (or restarted), it goes through phases:

- the workflow waits for any consumable resource to allow it to continue
- the workflow does a preflight check where it ensure that configuration in the output metadata is valid
- the workflow does a preflight check where it ensures that configuration in the output metadata is valid
- it provisions in any input files
- it runs the workflow
- it provisions out the results of the workflow
Expand Down
6 changes: 3 additions & 3 deletions plugin-guide.md
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ which ones are allowed via the `supports` method.
The workflow engine will be given the complete input to the workflow (with real
paths provided by the input provisioners) and the workflow itself. Once the
workflow has completed, it must provide a JSON structure that references the
output of the workflow. Vidarr will identified the output files generated by
output of the workflow. Vidarr will identify the output files generated by
the workflow engine and they will be passed to the output provisioners.

After the output provisioners have completed, the workflow engine will be
Expand Down Expand Up @@ -502,7 +502,7 @@ This changes the type of an input provider for compatibility with Shesmu. The
crux is this: Shesmu's tagged unions are more limited than Víðarr's. Shesmu
requires that a tagged union have a tuple or object while Víðarr permits either
of those. When using the _one-of_ input source, this introduces the possibility
of creating a type that Shesmu cannot process. This allows wrapping an
of creating a type that Shesmu cannot process. This allows wrapping a
priority input's type in a single element tuple, thereby making it compatible
with Shesmu.

Expand Down Expand Up @@ -613,7 +613,7 @@ priority is provided using the `"base"` formula.
Increases the priority as a workflow run sits around. The duration the workflow
run has been waiting is looked up in the `"escalation"` object; the keys are an
[ISO-8601 duration](https://en.wikipedia.org/wiki/ISO_8601#Durations) and the
values are a integer. The smallest matching duration is used and the value
values are an integer. The smallest matching duration is used and the value
provided is added to the original score. Values need to be greater than 1 to
increase priority. If workflow run has been waiting less than the smallest
duration in the dictionary, the original priority is used. The original
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ public interface ActiveOperation<TX> {
*/
boolean isLive();
/**
* Be told something something interesting
* Be told something interesting
*
* @param level how important this message is
* @param message the message to display
Expand Down
2 changes: 1 addition & 1 deletion vidarr-cromwell/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ using `"workflowSource"`. `"workflowOptions"` is the workflow options Cromwell
requires. Although Cromwell is given the entire workflow, it still needs to
know the WDL version, provided as `"wdlVersion"`. The workflow will be called
with two arguments, the file to copy (which will be provided as the argument
(`"fileField"`) and the submitter-provided archive directory
(`"fileField"`)) and the submitter-provided archive directory
(`"outputPrefixField"`). Once the workflow has completed, the plugin will
collect the permanent location for the file (`"storagePathField"`), the MD5
(`"md5Field"`), and the file size (`"fileSizeField"`).
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -813,7 +813,7 @@ public static BasicType tuple(BasicType... types) {
private BasicType() {}

/**
* Transform this type into a another representation
* Transform this type into another representation
*
* @param transformer the converter for each type
*/
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -909,7 +909,7 @@ public static InputType tuple(InputType... types) {
private InputType() {}

/**
* Transform this type into a another representation
* Transform this type into another representation
*
* @param transformer the converter for each type
*/
Expand Down

0 comments on commit 8b425c7

Please sign in to comment.