It is correct for a WAITING_FOR_RESOURCES job to have no active opera…

…tions This commit reverts 11dc61a and c656216
oicr-gsi · May 7, 2024 · ddc598a · ddc598a
1 parent c656216
commit ddc598a
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 8 deletions.
diff --git a/changes/fix_fix-bad-recovery.md b/changes/fix_fix-bad-recovery.md
@@ -0,0 +1,2 @@
+Fix broken recovery logic present from v0.19.0
+
diff --git a/vidarr-server/src/main/java/ca/on/oicr/gsi/vidarr/server/DatabaseBackedProcessor.java b/vidarr-server/src/main/java/ca/on/oicr/gsi/vidarr/server/DatabaseBackedProcessor.java
@@ -740,14 +740,6 @@ record ->
                                           final var activeOperations =
                                               operations.getOrDefault(
                                                   record.get(ACTIVE_WORKFLOW_RUN.ID), List.of());
-                                          if (activeOperations.isEmpty()) {
-                                            String erroneousHash = record.get(WORKFLOW_RUN.HASH_ID);
-                                            System.err.printf(
-                                                "Error recovering workflow run %s: no operations match\n",
-                                                erroneousHash);
-                                            BadRecoveryTracker.add(erroneousHash);
-                                            return;
-                                          }
                                           final var workflow =
                                               DatabaseWorkflow.recover(
                                                   target,
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		Fix broken recovery logic present from v0.19.0