Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

last access field in workflow runs updates properly #357

Merged
merged 3 commits into from
Feb 22, 2024

Conversation

grapigeau
Copy link
Contributor

last access field in workflow runs updates properly when run is submitted

Jira ticket: https://jira.oicr.on.ca/browse/GP-4147

  • [ x] Includes a change file
  • Updates developer documentation

avarsava
avarsava previously approved these changes Feb 16, 2024
@avarsava avarsava dismissed their stale review February 16, 2024 20:00

forgot to check something

@avarsava
Copy link
Contributor

avarsava commented Feb 16, 2024

This updates DatabaseWorkflow.create(), which gets called in launchNewWorkflowRun(), which only gets called if matching candidates.isEmpty() (ie, this is the first time this workflow run has been submitted). Do you want to handle the other cases too?

@grapigeau grapigeau requested a review from mlaszloffy February 22, 2024 14:48
@Christopher-Ho
Copy link
Contributor

So for understanding purposes this last accessed field was previously only set once (at time of creation) and never changed. Now we want it changed whenever the workflow is run. Which accurately represents the meaning of "last accessed".

@grapigeau grapigeau merged commit 93353b2 into master Feb 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants