Skip to content

Commit

Permalink
Replace Deno with Node.js
Browse files Browse the repository at this point in the history
  • Loading branch information
niedzielski committed Feb 4, 2024
1 parent 1413054 commit 80d32ca
Show file tree
Hide file tree
Showing 46 changed files with 5,982 additions and 3,001 deletions.
31 changes: 12 additions & 19 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,23 +12,16 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v3
- name: Install Deno
uses: denoland/setup-deno@v1
with:
deno-version: v1.x
- name: Type-check
run: deno task test:types
uses: actions/checkout@v4
- name: Install Node.js
uses: actions/setup-node@v4
- name: Install Dependencies
run: npm ci --no-fund
- name: Unit Test
run: deno task test:unit
- name: Lint
run: deno lint
- name: Format Test
run: deno fmt --check
- name: UI Test
run: deno task test:ui
# to-do: fix
# `Error: R] Directory not empty (os error 39): rename '/tmp/a3748ae3' -> '/home/runner/.cache/deno/deno_esbuild/@lit/[email protected]/node_modules/@lit/reactive-element' [plugin deno-loader]`
# error. https://github.com/oidoid/linear-text/actions/runs/7430168447/job/20219563902
# - name: Build
# run: deno task build
run: npm run test:unit
- name: Test Format
run: npm run test:format
- name: Type-check UI
run: npm run test:types:ui
- name: Build
run: npm run build
2 changes: 2 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1 +1,3 @@
/node_modules/
tsconfig.tsbuildinfo
/dist/
1 change: 1 addition & 0 deletions .prettierignore
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
/dist/
7 changes: 1 addition & 6 deletions .vscode/settings.json
Original file line number Diff line number Diff line change
@@ -1,6 +1 @@
{
"deno.enable": true,
"deno.lint": true,
"deno.unstable": true,
"editor.defaultFormatter": "denoland.vscode-deno"
}
{"typescript.tsdk": "node_modules/typescript/lib"}
36 changes: 0 additions & 36 deletions deno.json

This file was deleted.

13 changes: 0 additions & 13 deletions docs/to-do.text
Original file line number Diff line number Diff line change
Expand Up @@ -24,19 +24,6 @@ Bugs
Enter at the start of a line does nothing.
When I highlight text and alt-tab to another window, my highlight is lost.
When I delete a child's text, and shift-tab to focus the parent, I lose the focus.
File Deno bugs.
I can't do an exhaustive switch in the default case. `props.page.type satisfies never`
html and css template strings aren't formatted.
Some imports are pulled in from the Deno cache and never should be.
`npm:<package>/path` imports aren't suggested and the error message is confusing when these aren't aliased correctly in the import path.
Really need declare module support for representing bundling assets without hacks.
tools/build import auto-removal is erroneous.
Saving doesn't automatically add or remove imports like normal TypeScript.
Closest deno.json isn't used for import map or anything. These are available with quickfix though.
Possibly related https://github.com/denoland/vscode_deno/issues/1048
Deno doesn't auto-enable when deno.json is found. Prettier plugin does and it works great.
tools/build shebang ignored and read as JavaScript.
Markdown table in readme isn't the correct width.
unsaved favicon doesn't align perfectly to saved because SVG is used. Just use old png.
Fix CI builds and generate a next release.
I want a way to delete or add cards by clicking, including deleting groups and sub-lines.
Expand Down
Loading

0 comments on commit 80d32ca

Please sign in to comment.