Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cleanup oracle tests #293

Merged
merged 3 commits into from
Oct 13, 2023
Merged

chore: cleanup oracle tests #293

merged 3 commits into from
Oct 13, 2023

Conversation

zarazan
Copy link
Contributor

@zarazan zarazan commented Oct 6, 2023

Description

Remove the duplicate integration test setup from the oracle abci tests and utilize the new shared setup.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • added appropriate labels to the PR
  • targeted the correct branch
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@codecov-commenter
Copy link

Codecov Report

Merging #293 (35fd29d) into main (ef2d082) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@           Coverage Diff           @@
##             main     #293   +/-   ##
=======================================
  Coverage   19.04%   19.04%           
=======================================
  Files          54       54           
  Lines       13550    13550           
=======================================
  Hits         2581     2581           
  Misses      10849    10849           
  Partials      120      120           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@zarazan zarazan marked this pull request as ready for review October 13, 2023 14:14
@zarazan zarazan requested a review from a team as a code owner October 13, 2023 14:14
@zarazan zarazan merged commit 74059bd into main Oct 13, 2023
@zarazan zarazan deleted the zarazan/cleanup-oracle-tests branch October 13, 2023 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants