Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: axelar GMP relaying #304

Merged
merged 14 commits into from
Nov 9, 2023
Merged

feat: axelar GMP relaying #304

merged 14 commits into from
Nov 9, 2023

Conversation

adamewozniak
Copy link
Member

@adamewozniak adamewozniak commented Nov 4, 2023

Description

PR for the IBC logic of GMP

Ref: ojo-network/ojo-evm#3


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • added appropriate labels to the PR
  • targeted the correct branch
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@codecov-commenter
Copy link

codecov-commenter commented Nov 4, 2023

Codecov Report

Merging #304 (4810ae9) into main (69bcdb6) will decrease coverage by 1.41%.
The diff coverage is 5.78%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##             main     #304      +/-   ##
==========================================
- Coverage   17.03%   15.63%   -1.41%     
==========================================
  Files          56       75      +19     
  Lines       16153    18454    +2301     
==========================================
+ Hits         2752     2885     +133     
- Misses      13272    15435    +2163     
- Partials      129      134       +5     
Files Coverage Δ
x/gmp/genesis.go 100.00% <100.00%> (ø)
x/gmp/keeper/params.go 100.00% <100.00%> (ø)
x/gmp/abci.go 0.00% <0.00%> (ø)
x/gmp/keeper/keeper.go 80.00% <80.00%> (ø)
x/gmp/keeper/grpc_query.go 33.33% <33.33%> (ø)
x/gmp/types/codec.go 50.00% <50.00%> (ø)
x/oracle/keeper/params.go 91.95% <0.00%> (-8.05%) ⬇️
x/gmp/types/abi_encoding.go 42.85% <42.85%> (ø)
x/gmp/types/genesis.go 0.00% <0.00%> (ø)
x/gmp/client/tests/suite.go 70.90% <70.90%> (ø)
... and 10 more

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@adamewozniak
Copy link
Member Author

The vulnerability here in the dependency review warning is a graphql part of the go-ethereum package:

Description
Geth (aka go-ethereum) through 1.13.4, when --http --graphql is used, allows remote attackers to cause a denial of service (memory consumption and daemon hang) via a crafted GraphQL query.

NOTE: the vendor's position is that the "graphql endpoint [is not] designed to withstand attacks by hostile clients, nor handle huge amounts of clients/traffic.

References
https://nvd.nist.gov/vuln/detail/CVE-2023-42319
https://blog.mevsec.com/posts/geth-dos-with-graphql/
https://geth.ethereum.org/docs/fundamentals/security

I don't recommend we wait for this to be fixed by ethereum to merge.

@adamewozniak adamewozniak marked this pull request as ready for review November 8, 2023 22:48
@adamewozniak adamewozniak requested a review from a team as a code owner November 8, 2023 22:48
@adamewozniak adamewozniak changed the title feat: custom ibc logic feat: axelar GMP relaying Nov 8, 2023
Copy link
Collaborator

@rbajollari rbajollari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just nitpicks, most of the stuff missing looks addressed in your TODOs. lgtm 🔥

x/gmp/types/abi_encoding_test.go Outdated Show resolved Hide resolved
x/gmp/keeper/msg_server.go Outdated Show resolved Hide resolved
x/gmp/keeper/msg_server.go Outdated Show resolved Hide resolved
x/gmp/keeper/msg_server_test.go Show resolved Hide resolved
@mergify mergify bot merged commit 5e82697 into main Nov 9, 2023
25 of 26 checks passed
@mergify mergify bot deleted the woz/ibc-custom branch November 9, 2023 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants