Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: gmp follow-up #314

Closed
wants to merge 1 commit into from
Closed

feat: gmp follow-up #314

wants to merge 1 commit into from

Conversation

adamewozniak
Copy link
Member

Description

closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • added appropriate labels to the PR
  • targeted the correct branch
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@codecov-commenter
Copy link

Codecov Report

Merging #314 (1168214) into main (5e82697) will decrease coverage by 0.07%.
The diff coverage is 0.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##             main     #314      +/-   ##
==========================================
- Coverage   15.63%   15.56%   -0.07%     
==========================================
  Files          75       75              
  Lines       18454    18532      +78     
==========================================
  Hits         2885     2885              
- Misses      15435    15513      +78     
  Partials      134      134              
Files Coverage Δ
x/gmp/keeper/msg_server.go 10.00% <0.00%> (+0.27%) ⬆️
x/gmp/types/tx.pb.go 0.67% <0.00%> (-0.07%) ⬇️

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@adamewozniak adamewozniak changed the title feat: GMP follow-up feat: gmp follow-up Nov 10, 2023
@adamewozniak
Copy link
Member Author

closing this PR as the middleware PR changed a few things

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants