Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Memo in ibc transfer to axelar #335

Merged
merged 3 commits into from
Dec 13, 2023
Merged

fix: Memo in ibc transfer to axelar #335

merged 3 commits into from
Dec 13, 2023

Conversation

rbajollari
Copy link
Collaborator

Description

closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • added appropriate labels to the PR
  • targeted the correct branch
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@codecov-commenter
Copy link

codecov-commenter commented Dec 13, 2023

Codecov Report

Attention: 273 lines in your changes are missing coverage. Please review.

Comparison is base (71f1f9c) 15.81% compared to head (1eac151) 15.62%.

Files Patch % Lines
x/gmp/types/gmp.pb.go 0.38% 262 Missing ⚠️
x/gmp/types/params.go 0.00% 7 Missing ⚠️
x/gmp/types/msgs.go 0.00% 4 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #335      +/-   ##
==========================================
- Coverage   15.81%   15.62%   -0.20%     
==========================================
  Files          78       78              
  Lines       18955    19225     +270     
==========================================
+ Hits         2997     3003       +6     
- Misses      15804    16069     +265     
+ Partials      154      153       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rbajollari rbajollari marked this pull request as ready for review December 13, 2023 18:29
@rbajollari rbajollari requested a review from a team as a code owner December 13, 2023 18:29
@mergify mergify bot merged commit 7835c97 into main Dec 13, 2023
26 checks passed
@mergify mergify bot deleted the ryan/fix-gmp-encoding branch December 13, 2023 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants