Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Payload marshaling in gmp message generation #343

Merged
merged 6 commits into from
Dec 19, 2023

Conversation

rbajollari
Copy link
Collaborator

Description

closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • added appropriate labels to the PR
  • targeted the correct branch
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@codecov-commenter
Copy link

codecov-commenter commented Dec 19, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (66acbcd) 15.62% compared to head (b9043b9) 16.10%.
Report is 4 commits behind head on main.

Files Patch % Lines
x/gmp/keeper/keeper.go 63.63% 3 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #343      +/-   ##
==========================================
+ Coverage   15.62%   16.10%   +0.48%     
==========================================
  Files          78       78              
  Lines       19225    18765     -460     
==========================================
+ Hits         3003     3022      +19     
+ Misses      16069    15590     -479     
  Partials      153      153              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rbajollari rbajollari marked this pull request as ready for review December 19, 2023 18:56
@rbajollari rbajollari requested a review from a team as a code owner December 19, 2023 18:56
Copy link
Member

@adamewozniak adamewozniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! @rbajollari can you add an upgrade handler in this PR?

x/gmp/keeper/keeper.go Show resolved Hide resolved
@rbajollari rbajollari merged commit 5cc3e92 into main Dec 19, 2023
25 checks passed
@rbajollari rbajollari deleted the ryan/payload-marshaling branch December 19, 2023 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants