Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Upgrade tia branch to cosmos sdk v0.50.1 #382

Merged
merged 25 commits into from
Feb 16, 2024
Merged

Conversation

rbajollari
Copy link
Collaborator

Description

closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • added appropriate labels to the PR
  • targeted the correct branch
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@codecov-commenter
Copy link

codecov-commenter commented Feb 14, 2024

Codecov Report

Attention: 85 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (tia@60b6a01). Click here to learn what that means.

Files Patch % Lines
x/oracle/abci.go 51.61% 9 Missing and 6 partials ⚠️
x/oracle/keeper/historic_price.go 39.13% 14 Missing ⚠️
x/airdrop/keeper/airdrop_account.go 33.33% 9 Missing and 3 partials ⚠️
x/oracle/keeper/slash.go 63.15% 4 Missing and 3 partials ⚠️
x/oracle/keeper/migrations.go 0.00% 5 Missing ⚠️
x/oracle/keeper/reward.go 44.44% 3 Missing and 2 partials ⚠️
x/airdrop/module.go 42.85% 4 Missing ⚠️
x/oracle/keeper/keeper.go 77.77% 3 Missing and 1 partial ⚠️
x/oracle/module.go 42.85% 4 Missing ⚠️
x/gmp/module.go 50.00% 3 Missing ⚠️
... and 8 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@          Coverage Diff           @@
##             tia     #382   +/-   ##
======================================
  Coverage       ?   16.08%           
======================================
  Files          ?       78           
  Lines          ?    18785           
  Branches       ?        0           
======================================
  Hits           ?     3022           
  Misses         ?    15596           
  Partials       ?      167           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rbajollari rbajollari marked this pull request as ready for review February 16, 2024 17:41
@rbajollari rbajollari requested a review from a team as a code owner February 16, 2024 17:41
@adamewozniak
Copy link
Member

This advisory suggests we upgrade v0.38.1 -> v0.38.3

Copy link
Member

@adamewozniak adamewozniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK - great job @rbajollari !!!

@rbajollari rbajollari merged commit 8649e17 into tia Feb 16, 2024
23 of 24 checks passed
@rbajollari rbajollari deleted the ryan/upgrade-sdk-50 branch February 16, 2024 20:03
@adamewozniak
Copy link
Member

@Mergifyio backport main

Copy link
Contributor

mergify bot commented Feb 29, 2024

backport main

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Feb 29, 2024
* project builds

* fix unit tests

* go version in workflows

* some lint issues

* fix sim non determinism

* go version in workflows

* single node fix

* fix rollkit init-local

* init-local works

* try liveness with init-local

* update init_local to work in CI

* script permisions

* remove it option from docker run

* make celestia devnet run in background

* rollup script too

* comment out e2e

* some lint fixes

* use version latest in golangci-lint action

* more lint fixes

* silence lint error on usage of deprecated func

* fix .golangci.yml formatting

* add extra sleep in liveness

* cometbft to v0.38.5

* Update cmd/ojod/cmd/commands.go

Co-authored-by: Adam Wozniak <[email protected]>

* move TODO to top of file

---------

Co-authored-by: Adam Wozniak <[email protected]>
(cherry picked from commit 8649e17)

# Conflicts:
#	go.mod
#	go.sum
#	scripts/celestia_devnet.sh
#	tools/tools.go
rbajollari added a commit that referenced this pull request Feb 29, 2024
* project builds

* fix unit tests

* go version in workflows

* some lint issues

* fix sim non determinism

* go version in workflows

* single node fix

* fix rollkit init-local

* init-local works

* try liveness with init-local

* update init_local to work in CI

* script permisions

* remove it option from docker run

* make celestia devnet run in background

* rollup script too

* comment out e2e

* some lint fixes

* use version latest in golangci-lint action

* more lint fixes

* silence lint error on usage of deprecated func

* fix .golangci.yml formatting

* add extra sleep in liveness

* cometbft to v0.38.5

* Update cmd/ojod/cmd/commands.go

Co-authored-by: Adam Wozniak <[email protected]>

* move TODO to top of file

---------

Co-authored-by: Adam Wozniak <[email protected]>
(cherry picked from commit 8649e17)

# Conflicts:
#	go.mod
#	go.sum
#	scripts/celestia_devnet.sh
#	tools/tools.go
rbajollari added a commit that referenced this pull request Feb 29, 2024
* feat: Upgrade tia branch to cosmos sdk v0.50.1 (#382)

* project builds

* fix unit tests

* go version in workflows

* some lint issues

* fix sim non determinism

* go version in workflows

* single node fix

* fix rollkit init-local

* init-local works

* try liveness with init-local

* update init_local to work in CI

* script permisions

* remove it option from docker run

* make celestia devnet run in background

* rollup script too

* comment out e2e

* some lint fixes

* use version latest in golangci-lint action

* more lint fixes

* silence lint error on usage of deprecated func

* fix .golangci.yml formatting

* add extra sleep in liveness

* cometbft to v0.38.5

* Update cmd/ojod/cmd/commands.go

Co-authored-by: Adam Wozniak <[email protected]>

* move TODO to top of file

---------

Co-authored-by: Adam Wozniak <[email protected]>
(cherry picked from commit 8649e17)

# Conflicts:
#	go.mod
#	go.sum
#	scripts/celestia_devnet.sh
#	tools/tools.go

* fix merge conflicts

* liveness test

* merge conflict in tools

---------

Co-authored-by: ryanbajollari <[email protected]>
Co-authored-by: rbajollari <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants