Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Switch from stdlib json encoding to proto encoding in vote extension handler #516

Merged
merged 9 commits into from
Sep 23, 2024

Conversation

rbajollari
Copy link
Collaborator

@rbajollari rbajollari commented Sep 18, 2024

…cle is not set

Description

closes: #411


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • added appropriate labels to the PR
  • targeted the correct branch
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@rbajollari rbajollari requested a review from a team as a code owner September 18, 2024 15:24
x/oracle/abci/proposal.go Fixed Show fixed Hide fixed
@rbajollari rbajollari changed the title fix: Create vote extension with no exchange rates if price feeder ora… fix: Switch from stdlib json encoding to proto encoding in vote extension handler Sep 20, 2024
@rbajollari rbajollari merged commit 65e8943 into main Sep 23, 2024
24 of 25 checks passed
@rbajollari rbajollari deleted the ryan/handle-pforacle-set branch September 23, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch from stdlib JSON encoding to a more performant mechanism in oracle proposal handler
2 participants