Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: payment trigger percentage & 0.5.1 update #532

Merged
merged 4 commits into from
Oct 7, 2024
Merged

fix: payment trigger percentage & 0.5.1 update #532

merged 4 commits into from
Oct 7, 2024

Conversation

adamewozniak
Copy link
Member

Description

  • The trigger to process a payment had a bug where it would trigger if the "whole number" of the deviation of the payment had changed. E.g, if the existing price is $200, and the new price is $201, and deviation is 1, it would have triggered.
  • Also adds the 0.5.1 upgrade
    • updates the gasestimate module's gas adjustment parameter to 0.35

@adamewozniak adamewozniak requested a review from a team as a code owner October 4, 2024 22:19
adamewozniak
adamewozniak commented Oct 4, 2024
View reviewed changes
app/upgrades.go Outdated Show resolved Hide resolved
@adamewozniak adamewozniak merged commit 602c1c6 into main Oct 7, 2024
23 of 25 checks passed
@adamewozniak adamewozniak deleted the woz/payment-trigger-update branch October 7, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbajollari rbajollari rbajollari approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adamewozniak @rbajollari