Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Read currency pair providers and deviations from on chain params #260

Merged
merged 14 commits into from
Oct 31, 2023

Conversation

rbajollari
Copy link
Collaborator

@rbajollari rbajollari commented Sep 11, 2023

Description

  • Adds chain-config flag to use currency pair providers and currency deviations from Ojo's oracle params instead of the config file
  • Every time the param cache is updated, if the currency pair providers and currency deviations have been changed the price feeder will use the updated ones if it was started using the chain-config flag (param cache is updated every 200 blocks or after param update event)

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • added appropriate labels to the PR
  • targeted the correct branch
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@rbajollari rbajollari marked this pull request as ready for review October 11, 2023 01:11
@rbajollari rbajollari requested a review from a team as a code owner October 11, 2023 01:11
Copy link
Contributor

@zarazan zarazan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments are mostly cosmetic. Looks good, very exciting!

cmd/price-feeder.go Show resolved Hide resolved
oracle/oracle.go Outdated Show resolved Hide resolved
oracle/oracle.go Outdated Show resolved Hide resolved
@rbajollari rbajollari merged commit 4ff8c0e into main Oct 31, 2023
14 of 16 checks passed
@rbajollari rbajollari deleted the ryan/query-currency-pairs branch October 31, 2023 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants