Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Don't fail the entire provider when one asset is missing #262

Merged
merged 3 commits into from
Sep 12, 2023

Conversation

zarazan
Copy link
Contributor

@zarazan zarazan commented Sep 12, 2023

Description

Modifies the Oracle.SetPrices() go routine such that when both the ticker and candle prices are missing for one asset pair it does not skip other existing valid pairs.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • added appropriate labels to the PR
  • targeted the correct branch
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@zarazan zarazan requested a review from a team as a code owner September 12, 2023 15:56
@zarazan zarazan added the S:backport/umee Backport changes to umee branch label Sep 12, 2023
@zarazan zarazan merged commit 54b49cd into main Sep 12, 2023
@zarazan zarazan deleted the zarazan/fix-error-per-pair branch September 12, 2023 19:53
mergify bot pushed a commit that referenced this pull request Sep 12, 2023
* dont fail the entire provider when one asset is missing

(cherry picked from commit 54b49cd)

# Conflicts:
#	ojo-provider-config/endpoints.toml
zarazan added a commit that referenced this pull request Sep 13, 2023
#262) (#264)

* fix: Don't fail the entire provider when one asset is missing (#262)

* dont fail the entire provider when one asset is missing

(cherry picked from commit 54b49cd)

# Conflicts:
#	ojo-provider-config/endpoints.toml

* backport merge conflict

---------

Co-authored-by: Kyle <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S:backport/umee Backport changes to umee branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants