Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update gate provider candle parsing #313

Merged
merged 1 commit into from
Nov 21, 2023
Merged

fix: update gate provider candle parsing #313

merged 1 commit into from
Nov 21, 2023

Conversation

zarazan
Copy link
Contributor

@zarazan zarazan commented Nov 21, 2023

Description

  • Updates a validation check on the candle payload from the gate provider.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • added appropriate labels to the PR
  • targeted the correct branch
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@zarazan zarazan requested a review from a team as a code owner November 21, 2023 05:55
@zarazan zarazan added the S:backport/umee Backport changes to umee branch label Nov 21, 2023
adamewozniak
adamewozniak approved these changes Nov 21, 2023
View reviewed changes
Copy link
Member

@adamewozniak adamewozniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad we fixed the candle -> ticker circuit breaker

@zarazan zarazan merged commit 4d8d0a8 into main Nov 21, 2023
15 of 16 checks passed
@zarazan zarazan deleted the zarazan/fix-gate-candle branch November 21, 2023 17:29
mergify bot pushed a commit that referenced this pull request Nov 21, 2023
@zarazan @mergify
fix gate provider candle parsing (#313)
938c1dd 
(cherry picked from commit 4d8d0a8)
@mergify mergify bot mentioned this pull request Nov 21, 2023
Merged
adamewozniak added a commit that referenced this pull request Nov 30, 2023
@mergify @zarazan @adamewozniak
fix gate provider candle parsing (#313) (#315)
10bf61c 
(cherry picked from commit 4d8d0a8)

Co-authored-by: Kyle <[email protected]>
Co-authored-by: Adam Wozniak <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamewozniak adamewozniak adamewozniak approved these changes

Assignees
No one assigned
Labels
S:backport/umee Backport changes to umee branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zarazan @adamewozniak