Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Handle astroport asset response returning inconsistent data type #332

Merged
merged 8 commits into from
Jan 17, 2024
Merged

fix: Handle astroport asset response returning inconsistent data type #332

merged 8 commits into from
Jan 17, 2024

Conversation

rbajollari
Copy link
Collaborator

… for quote symbol field

Description

closes: #XXXX

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • added appropriate labels to the PR
  • targeted the correct branch
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@rbajollari rbajollari requested a review from a team as a code owner January 16, 2024 20:13
adamewozniak
adamewozniak approved these changes Jan 16, 2024
View reviewed changes
Copy link
Member

@adamewozniak adamewozniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, aside from the lint issue + testing

@adamewozniak adamewozniak changed the title fix: Handle astroport asset response returning inconsistent data type… fix: Handle astroport asset response returning inconsistent data type Jan 17, 2024
@adamewozniak adamewozniak merged commit 98aa88b into main Jan 17, 2024
15 of 17 checks passed
@adamewozniak adamewozniak deleted the ryan/fix-astroport-provider branch January 17, 2024 03:35
@adamewozniak adamewozniak added the S:backport/umee Backport changes to umee branch label Jan 17, 2024
@adamewozniak
Copy link
Member

@Mergifyio backport umee

@mergify Mergify
Copy link

mergify bot commented Jan 17, 2024 •
edited
Loading

backport umee

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jan 17, 2024
@rbajollari @mergify
fix: Handle astroport asset response returning inconsistent data type (…
abc89ea 
…#332)

* fix: Handle astroport asset response returning inconsistent data type for quote symbol field

* increase sleep time

* increase sleep time again

* lint

* lint

* type switch with assignment

* fix checkprovidermin test

---------

Co-authored-by: Adam Wozniak <[email protected]>
(cherry picked from commit 98aa88b)

# Conflicts:
#	oracle/provider/astroport.go
#	oracle/provider/astroport_test.go
@mergify mergify bot mentioned this pull request Jan 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamewozniak adamewozniak adamewozniak approved these changes

Assignees
No one assigned
Labels
S:backport/umee Backport changes to umee branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rbajollari @adamewozniak